Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/config-policy-controller: #222 #793

Merged
merged 4 commits into from
Apr 10, 2024

Conversation

magic-mirror-bot[bot]
Copy link

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
(cherry picked from commit 0c17093)
Also adjusts CSV reporting to handle when the CSV exists but the
subscription does not, by using a label that OLM adds to these objects.

The authorino operator was chosen because it has more than one CRD, but
not too many to make a concise test.

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
(cherry picked from commit 6b1db91)
When the subscription has a ConstraintsNotSatisfiable condition, the
exact content of the message is not always consistent. We have added
other things to sort the message better, but it looks like we missed
this test which was still assuming a certain part was first.

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
(cherry picked from commit 12f0324)
Enforced mustnohave policies will delete things based on the new
RemovalBehavior field. In inform mode, resources that would be removed
by an enforced policy will be causes for NonCompliance. This gives
control to users in order to prevent unintended side effects.

Refs:
 - https://issues.redhat.com/browse/ACM-9287

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
(cherry picked from commit 1711136)
Copy link

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign yiraechristinekim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Apr 10, 2024

@magic-mirror-bot magic-mirror-bot bot merged commit 1942d55 into main Apr 10, 2024
13 of 14 checks passed
@magic-mirror-bot magic-mirror-bot bot deleted the magic-mirror-main-1712776792452 branch April 10, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant